Improved : Improve User Feedback When Lacking Commerce_View Permission (launchpad-132) #834
Conversation
…n (launchpad-132)
Summary of ChangesHello @Nirvan-Bobde30, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances user experience by providing clearer feedback regarding access to the Order Management System (OMS). It introduces a new permission check that disables the 'Go to OMS' button in the settings if the user lacks the required Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly implements the intended feature of disabling the 'Go to OMS' button when the user lacks the APP_COMMERCE_VIEW permission. The changes are well-contained, adding the new action and its corresponding rule, and then applying the permission check in the UI. I have one suggestion in src/views/Settings.vue to improve code readability by moving the complex condition for the button's disabled state into a computed property. This will make the template cleaner and the logic easier to maintain.
| {{ $t('This is the name of the OMS you are connected to right now. Make sure that you are connected to the right instance before proceeding.') }} | ||
| </ion-card-content> | ||
| <ion-button v-if="!authStore.isEmbedded" :disabled="!omsRedirectionInfo.token || !omsRedirectionInfo.url" @click="goToOms(omsRedirectionInfo.token, omsRedirectionInfo.url)" fill="clear"> | ||
| <ion-button v-if="!authStore.isEmbedded" :disabled="!omsRedirectionInfo.token || !omsRedirectionInfo.url || !hasPermission(Actions.APP_COMMERCE_VIEW)" @click="goToOms(omsRedirectionInfo.token, omsRedirectionInfo.url)" fill="clear"> |
There was a problem hiding this comment.
For better readability and maintainability, consider extracting the logic for the :disabled attribute into a computed property. This keeps the template cleaner and centralizes the logic in the script section.
You could add a computed property like this in your <script setup>:
const isGoToOmsDisabled = computed(() => {
return !omsRedirectionInfo.value.token || !omsRedirectionInfo.value.url || !hasPermission(Actions.APP_COMMERCE_VIEW);
});And then use it in the template:
<ion-button ... :disabled="isGoToOmsDisabled" ...>1 participant
Related Issues
hotwax/launchpad#132
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance